🚀 go-pugleaf

Distopico <distopico@riseup.net> writes:

> Hi all!
>
> I'm the author of a new package `flymake-guile` and I
> would like to include it in Nongnu ELPA.

Just to be sure, you are sure you don't want to include your package in
GNU ELPA?

> Here the repo: https://framagit.org/flymake-backends/flymake-guile

I am not familiar with the "flymake-quickdef" package, but it doesn't
seem to be much shorter than just defining a regular flymake backend.
As there have been some discussions wrt providing a kind of DSL for
Flymake backends, I am not sure if adding flymake-quickdef would be that
constructive at this point.  Would you consider updating your package to
not use the dependency?  You can check out other flymake-... modes in
GNU and NonGNU ELPA for inspiration.

> ;;; Commentary:
>
> ;; Flymake backend for GNU Guile using `guild' compile.
> ;;
> ;; Usage:
> ;;   (require 'flymake-guile)
> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)

It would probably make sense to autoload the `flymake-guile' function,
so that it is not necessary to require it in a user configuration.

> Best!
>
> From c6a3d53bb56d3e0d8638fe069a49fc4d364e0e84 Mon Sep 17 00:00:00 2001
> From: Distopico <distopico@riseup.net>
> Date: Wed, 30 Aug 2023 20:41:28 -0500
> Subject: [PATCH 1/2] * elpa-packages (flymake-quickdef): New package
>
> ---
>  elpa-packages | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 0d9da00c84..93e7c38600 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -220,6 +220,9 @@
>    :ignored-files (".travis.yml" "Cask" "LICENSE" "tests" "Makefile"
>                    "flx.el" "misc/flx-helm-demo.el" "misc/flx-test-list.el"))
>
> + (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
> +  :readme "README.md")
> +
>   (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
>    :ignored-files ("COPYING.txt"))
>
> --
> 2.41.0
>
>
> From 50674f93285692a4e7ca1c9b22d13bbffa89eabe Mon Sep 17 00:00:00 2001
> From: Distopico <distopico@riseup.net>
> Date: Wed, 30 Aug 2023 20:53:27 -0500
> Subject: [PATCH 2/2] * elpa-packages (flymake-guile): New package
>
> ---
>  elpa-packages | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 93e7c38600..b07894fe1a 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -223,6 +223,9 @@
>   (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
>    :readme "README.md")
>
> + (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
> +  :readme "README.md")

Are you sure the README.md is right thing to include here?  It includes
installation instructions, that are usually redundant when you install
the package using package.el.  I would recommend writing out the
"Commentary" section in flymake-guile.el with a brief description of
what package and its entry points.

Also, the package appears to include files that needn't be distributed
in the release tarball, such as .envrc and guix.scm.  It would be nice
if you could track these and future files of this type in a .elpaignore
file, to instruct the build server that they should be removed before
packaging.

> > +
>   (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
>    :ignored-files ("COPYING.txt"))

On 30/8/23 23:23, Distopico wrote:
 > Hi all!
 >
 > I'm the author of a new package `flymake-guile` and I
 > would like to include it in Nongnu ELPA.
 >
 > Here the repo: https://framagit.org/flymake-backends/flymake-guile
 >
 > --8<---------------cut here---------------start------------->8---
 > ;;; Commentary:
 >
 > ;; Flymake backend for GNU Guile using `guild' compile.
 > ;;
 > ;; Usage:
 > ;;   (require 'flymake-guile)
 > ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
 > --8<---------------cut here---------------end--------------->8---
 >
 > Best!
 >

Hi,

I've got a couple of comments about the defcustoms:

(defcustom flymake-guile-guild-args nil
   "Additional arguments for `guild' compile command."
   :type 'string
   :group 'flymake-guile)

Looks like either type should allow the nil value, or the default value
should be changed to a string.


(defcustom flymake-guile-warnings '("3")
   "A list of warnings to enable for `guild compile'.

The value of this variable could be an list string of warning types
or an warning level.

The list of supported warning types/levels can be found by running
`guild compile -W help'."
   :type  '(string)
   :group 'flymake-guile)

It looks like you want the :type to be a list of strings.  In that case
you should use (repeat string) as the :type.

Hi!

Distopico <distopico@riseup.net> writes:

> Hi all!
>
> I'm the author of a new package `flymake-guile` and I
> would like to include it in Nongnu ELPA.
>
> Here the repo: https://framagit.org/flymake-backends/flymake-guile

Thanks.

Since you're the only author, how would you feel about adding it to
GNU ELPA instead?

One important difference between GNU ELPA and NonGNU ELPA is that any
significant contribution (typically more than 15 lines) would need its
copyright assigned to the FSF.  See:
https://www.gnu.org/licenses/why-assign.html

On the other hand, GNU ELPA is more tightly integrated with the rest of Emacs.

> --8<---------------cut here---------------start------------->8---
> ;;; Commentary:
>
> ;; Flymake backend for GNU Guile using `guild' compile.
> ;;
> ;; Usage:
> ;;   (require 'flymake-guile)

I don't think there is any need to require it, as the `flymake-guile'
function is autoloaded.  So the `require' will just slow down starting
Emacs, if a user adds it to their init file.

> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)

You could also consider including this form:

(use-package flymake-guile
   :ensure t
   :hook (scheme-mode-hook . flymake-guile))

--=-=-Content-Type: text/plain


On 2023-08-31, Stefan Kangas <stefankangas@gmail.com> wrote:

> Hi!
>
> Distopico <distopico@riseup.net> writes:
>
>> Hi all!
>>
>> I'm the author of a new package `flymake-guile` and I
>> would like to include it in Nongnu ELPA.
>>
>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>
> Thanks.
>
> Since you're the only author, how would you feel about adding it to
> GNU ELPA instead?
>
> One important difference between GNU ELPA and NonGNU ELPA is that any
> significant contribution (typically more than 15 lines) would need its
> copyright assigned to the FSF.  See:
> https://www.gnu.org/licenses/why-assign.html
>
> On the other hand, GNU ELPA is more tightly integrated with the rest of Emacs.
>

Thank you for your feedback, for now I'm fine having it in NonGNU ELPA


>> --8<---------------cut here---------------start------------->8---
>> ;;; Commentary:
>>
>> ;; Flymake backend for GNU Guile using `guild' compile.
>> ;;
>> ;; Usage:
>> ;;   (require 'flymake-guile)
>
> I don't think there is any need to require it, as the `flymake-guile'
> function is autoloaded.  So the `require' will just slow down starting
> Emacs, if a user adds it to their init file.
>
>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>
> You could also consider including this form:
>
> (use-package flymake-guile
>    :ensure t
>    :hook (scheme-mode-hook . flymake-guile))
I apply that recommendation, not you can see the change in the repo

thank you.

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmTwuo0VHGRpc3RvcGlj
b0ByaXNldXAubmV0AAoJEJgJOoByVGvzYAwH/RvBR4NFAoN5B6ucynX6eMUi800B
IEpydDwxvRbrS499yZURgGxHS5KH7QtLxWO1KVik0qxpAa8z0kgeqO5ad9xM7A5Y
DcQ7PDY/t9CZn1xWhOZLGoKniGhtrZtroOE2PnWZhGvExOe2ymapq+xVsDrgIjTi
XX9j/p87Bo+/DYS+u9wqJWwIoEqatmamO+NcQeEKljdcIVpPySv8o2jv/vxUJ75O
oVty3FBOHMGvD45ADPqCOLdwNyXkXTaR272JI2TQ2CpmkIm4Nl8ZS9yND3J4UZi8
wsKQT6f50rfUogOoH47cUy1z3LNbWLe1SgOJZLW+NfGY9TC8It/Yxzfqq90=pkpT
-----END PGP SIGNATURE-----
--=-=-=--

--=-=-Content-Type: text/plain


On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> Hi all!
>>
>> I'm the author of a new package `flymake-guile` and I
>> would like to include it in Nongnu ELPA.
>
> Just to be sure, you are sure you don't want to include your package in
> GNU ELPA?
>
>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>
> I am not familiar with the "flymake-quickdef" package, but it doesn't
> seem to be much shorter than just defining a regular flymake backend.
> As there have been some discussions wrt providing a kind of DSL for
> Flymake backends, I am not sure if adding flymake-quickdef would be that
> constructive at this point.  Would you consider updating your package to
> not use the dependency?  You can check out other flymake-... modes in
> GNU and NonGNU ELPA for inspiration.
>
Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
and for now I would like to keep `flymake-quickdef`, I have plans to
write other backend and I don't wanna repeat the same validations and
code over and over, I'll switch to the DLS when it is implemented.

>> ;;; Commentary:
>>
>> ;; Flymake backend for GNU Guile using `guild' compile.
>> ;;
>> ;; Usage:
>> ;;   (require 'flymake-guile)
>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>
> It would probably make sense to autoload the `flymake-guile' function,
> so that it is not necessary to require it in a user configuration.
>
It already have autoload, I just update the commentary there.

>
> Are you sure the README.md is right thing to include here?  It includes
> installation instructions, that are usually redundant when you install
> the package using package.el.  I would recommend writing out the
> "Commentary" section in flymake-guile.el with a brief description of
> what package and its entry points.
>
> Also, the package appears to include files that needn't be distributed
> in the release tarball, such as .envrc and guix.scm.  It would be nice
> if you could track these and future files of this type in a .elpaignore
> file, to instruct the build server that they should be removed before
> packaging.
>
Updated in the last version ignoring those file and removing the README
declaration.

Thank you!

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmTwvC4VHGRpc3RvcGlj
b0ByaXNldXAubmV0AAoJEJgJOoByVGvzuboH/iUzuhzTNtHc1tG+2WKJ5Od1QyWy
NUoMjyUkqSxORTe3FfCZTXC8SnvzFTRBBGLWj3+SHiiyzqNUKeNJYJROirT2DOfE
GKyPrUCANyxtjYBuwiimsuht6KSF97EuzEsAPbCgMScgW43CXTC0VR50wCLFqP3H
UenDZ0H3HyELrXiZL6yBrnQGaiV65Um8te7dviYty3NQjrkKad8S4oRrh4LG8JG6
2LaVQG1FZwlom/wCm4+/5KhcLqx0UvKgsBW1CHO65u5qlCa3plSvFZoxc8JsnmFV
fx+hTE4HXCTXDsu4tXY3copdMkDJMHM/T0buDCrD5EXQUKeXYEnck9fXMJ4=S3y4
-----END PGP SIGNATURE-----
--=-=-=--

--=-=-Content-Type: text/plain


Hi Mauro, thank for your feedback.

On 2023-08-31, Mauro Aranda <maurooaranda@gmail.com> wrote:

> On 30/8/23 23:23, Distopico wrote:
>> Hi all!
>>
>> I'm the author of a new package `flymake-guile` and I
>> would like to include it in Nongnu ELPA.
>>
>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>
>> --8<---------------cut here---------------start------------->8---
>> ;;; Commentary:
>>
>> ;; Flymake backend for GNU Guile using `guild' compile.
>> ;;
>> ;; Usage:
>> ;;   (require 'flymake-guile)
>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>> --8<---------------cut here---------------end--------------->8---
>>
>> Best!
>>
>
> Hi,
>
> I've got a couple of comments about the defcustoms:
>
> (defcustom flymake-guile-guild-args nil
>   "Additional arguments for `guild' compile command."
>   :type 'string
>   :group 'flymake-guile)
>
> Looks like either type should allow the nil value, or the default value
> should be changed to a string.
>
>
> (defcustom flymake-guile-warnings '("3")
>   "A list of warnings to enable for `guild compile'.
>
> The value of this variable could be an list string of warning types
> or an warning level.
>
> The list of supported warning types/levels can be found by running
> `guild compile -W help'."
>   :type  '(string)
>   :group 'flymake-guile)
>
> It looks like you want the :type to be a list of strings.  In that case
> you should use (repeat string) as the :type.

I updated the code changing these, you can check the repo again and will
contain these changes.

Thanks!

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmTwvHcVHGRpc3RvcGlj
b0ByaXNldXAubmV0AAoJEJgJOoByVGvzoFcIAIodeCoMOad35V9l/SWLAsMIBEgi
i1P7VLatdX8R9c6BuFkgrpFq2oD6hARen4LhgO1gOhhR/tr8qnH3fGSI3+mCnd0N
JyhVaJQ6AtbiVrLdUejVZPGgq/EVuxtMVua2VsgVoGu42CLC9iRoakdgU3BvLc3/
UCilbvFg/uTvR2ry+en7BfqsrX4O6kzMAOI0YTSqroL6K3sPvxLj/rZfCp2G3xsY
CHeGNO7Cv57UXkz33KYYA7Cmejf5qLdTzca9BMhkswLJo4opmG9f7M1FIsAp0+az
lqrdWVTNgC3t+mNa4tolDc3BG651stDBgLarrgdo6HjQzrw1WHYdmP+nwxk=V9zn
-----END PGP SIGNATURE-----
--=-=-=--

--=-=-Content-Type: text/plain


v1 -> v2: Remove unnecesary README and ignore files.


--=-=-Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=v2-0001-elpa-packages-flymake-quickdef-New-package.patch

From c6a3d53bb56d3e0d8638fe069a49fc4d364e0e84 Mon Sep 17 00:00:00 2001
From: Distopico <distopico@riseup.net>
Date: Wed, 30 Aug 2023 20:41:28 -0500
Subject: [PATCH v2 1/2] * elpa-packages (flymake-quickdef): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 0d9da00c84..93e7c38600 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -220,6 +220,9 @@
   :ignored-files (".travis.yml" "Cask" "LICENSE" "tests" "Makefile"
                   "flx.el" "misc/flx-helm-demo.el" "misc/flx-test-list.el"))

+ (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
+  :readme "README.md")
+
  (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))


base-commit: aba50eda61cc6083f7cd0b87bee5dcd21fbb40bc
--
2.41.0


--=-=-Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=v2-0002-elpa-packages-flymake-guile-New-package.patch

From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001
From: Distopico <distopico@riseup.net>
Date: Wed, 30 Aug 2023 20:53:27 -0500
Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package

---
 elpa-packages | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 93e7c38600..e80486aec6 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -223,6 +223,9 @@
  (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
   :readme "README.md")

+ (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
+  :ignored-files (".envrc" "guix.scm"))
+
  (flymake-kondor	:url "https://github.com/turbo-cafe/flymake-kondor"
   :ignored-files ("COPYING.txt"))

--
2.41.0


--=-=-=--

--=-=-Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>
>>> Distopico <distopico@riseup.net> writes:
>>>
>>>> Hi all!
>>>>
>>>> I'm the author of a new package `flymake-guile` and I
>>>> would like to include it in Nongnu ELPA.
>>>
>>> Just to be sure, you are sure you don't want to include your package in
>>> GNU ELPA?
>>>
>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>
>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>> seem to be much shorter than just defining a regular flymake backend.
>>> As there have been some discussions wrt providing a kind of DSL for
>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>> constructive at this point.  Would you consider updating your package to
>>> not use the dependency?  You can check out other flymake-... modes in
>>> GNU and NonGNU ELPA for inspiration.
>>>
>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>> and for now I would like to keep `flymake-quickdef`, I have plans to
>> write other backend and I don't wanna repeat the same validations and
>> code over and over, I'll switch to the DLS when it is implemented.
>
> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>
> And just to make sure, you are certain you want to implement this on top
> of a DSL?  I have to admit that I am really not a fan of the way that
> flymake-quickdef is implemented, but one redeeming feature appears to be
> that you could macroexpand it away, then clean the code up.
>

flymake-collection use an adaptation of flymake-quickdef[1], that is
a macro similar to the quickdef one[2], could be use quickdef a blocker
to add the package on NonGNU ELPA?

>>>> ;;; Commentary:
>>>>
>>>> ;; Flymake backend for GNU Guile using `guild' compile.
>>>> ;;
>>>> ;; Usage:
>>>> ;;   (require 'flymake-guile)
>>>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>>>
>>> It would probably make sense to autoload the `flymake-guile' function,
>>> so that it is not necessary to require it in a user configuration.
>>>
>> It already have autoload, I just update the commentary there.
>
> 1+
>
>>>
>>> Are you sure the README.md is right thing to include here?  It includes
>>> installation instructions, that are usually redundant when you install
>>> the package using package.el.  I would recommend writing out the
>>> "Commentary" section in flymake-guile.el with a brief description of
>>> what package and its entry points.
>>>
>>> Also, the package appears to include files that needn't be distributed
>>> in the release tarball, such as .envrc and guix.scm.  It would be nice
>>> if you could track these and future files of this type in a .elpaignore
>>> file, to instruct the build server that they should be removed before
>>> packaging.
>>>
>> Updated in the last version ignoring those file and removing the README
>> declaration.
>>
>> Thank you!
>
> Distopico <distopico@riseup.net> writes:
>
>> v1 -> v2: Remove unnecesary README and ignore files.
>>
>>
>> From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001
>> From: Distopico <distopico@riseup.net>
>> Date: Wed, 30 Aug 2023 20:53:27 -0500
>> Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package
>>
>> ---
>>  elpa-packages | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/elpa-packages b/elpa-packages
>> index 93e7c38600..e80486aec6 100644
>> --- a/elpa-packages
>> +++ b/elpa-packages
>> @@ -223,6 +223,9 @@
>>   (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
>>    :readme "README.md")
>>  
>> + (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
>> +  :ignored-files (".envrc" "guix.scm"))
>
> It would be preferable to track this information in your own repository,
> instead of having to update the info in the future in elpa-packages.
>
> Also, it is totally fine to add both packages in a single patch.
I will keep it in mind in the future., thank you

Footnotes:
[1]  https://github.com/mohkale/flymake-collection#flymake-quickdef

[2]  https://github.com/mohkale/flymake-collection/blob/release/src/flymake-collection-define.el#L134


--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmTw6scVHGRpc3RvcGlj
b0ByaXNldXAubmV0AAoJEJgJOoByVGvzUcYH/3LeTYHVtjL+G/aOY23tGZm3Nhyj
BTWc35TRgE51/fwhC0sTEoPByBG8/ZFqwZCGH2lSxqnWXwI0dgAociJPGdUKV0dF
suMUEA9mch3Fti1rNtNbOP+6pPst877yk9/DF9LCl/9BAbap6aT4S0kGfi6L9XXJ
u42OaAJ5rUwqkzoutiBQb8uPq/rE7NvK0MnDeoCrfISFHTzIXG90KXOKsKu82p2Q
y6GeFgvkafBSuJatChMZ8rQ0R0su8B2ZXYnEnhpI8qEm/JzRgyIq+9fo0w38anSA
X88E4dSIBqNK7g1unT8+lYgYQ+q+7Q0EdTQ5T59m8Vez8JadmDuOef/e9e0=w8vo
-----END PGP SIGNATURE-----
--=-=-=--

Distopico <distopico@riseup.net> writes:

> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Distopico <distopico@riseup.net> writes:
>>
>>> Hi all!
>>>
>>> I'm the author of a new package `flymake-guile` and I
>>> would like to include it in Nongnu ELPA.
>>
>> Just to be sure, you are sure you don't want to include your package in
>> GNU ELPA?
>>
>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>
>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>> seem to be much shorter than just defining a regular flymake backend.
>> As there have been some discussions wrt providing a kind of DSL for
>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>> constructive at this point.  Would you consider updating your package to
>> not use the dependency?  You can check out other flymake-... modes in
>> GNU and NonGNU ELPA for inspiration.
>>
> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
> and for now I would like to keep `flymake-quickdef`, I have plans to
> write other backend and I don't wanna repeat the same validations and
> code over and over, I'll switch to the DLS when it is implemented.

FWIW it already exists in this form https://github.com/mohkale/flymake-collection.

And just to make sure, you are certain you want to implement this on top
of a DSL?  I have to admit that I am really not a fan of the way that
flymake-quickdef is implemented, but one redeeming feature appears to be
that you could macroexpand it away, then clean the code up.

>>> ;;; Commentary:
>>>
>>> ;; Flymake backend for GNU Guile using `guild' compile.
>>> ;;
>>> ;; Usage:
>>> ;;   (require 'flymake-guile)
>>> ;;   (add-hook 'scheme-mode-hook 'flymake-guile)
>>
>> It would probably make sense to autoload the `flymake-guile' function,
>> so that it is not necessary to require it in a user configuration.
>>
> It already have autoload, I just update the commentary there.

1+

>>
>> Are you sure the README.md is right thing to include here?  It includes
>> installation instructions, that are usually redundant when you install
>> the package using package.el.  I would recommend writing out the
>> "Commentary" section in flymake-guile.el with a brief description of
>> what package and its entry points.
>>
>> Also, the package appears to include files that needn't be distributed
>> in the release tarball, such as .envrc and guix.scm.  It would be nice
>> if you could track these and future files of this type in a .elpaignore
>> file, to instruct the build server that they should be removed before
>> packaging.
>>
> Updated in the last version ignoring those file and removing the README
> declaration.
>
> Thank you!

Distopico <distopico@riseup.net> writes:

> v1 -> v2: Remove unnecesary README and ignore files.
>
>
> From 1f683e46e59f5ebff923b493aa911e489ecd7bb0 Mon Sep 17 00:00:00 2001
> From: Distopico <distopico@riseup.net>
> Date: Wed, 30 Aug 2023 20:53:27 -0500
> Subject: [PATCH v2 2/2] * elpa-packages (flymake-guile): New package
>
> ---
>  elpa-packages | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/elpa-packages b/elpa-packages
> index 93e7c38600..e80486aec6 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -223,6 +223,9 @@
>   (flymake-quickdef      :url "https://github.com/karlotness/flymake-quickdef.git"
>    :readme "README.md")
>
> + (flymake-guile		:url "https://framagit.org/flymake-backends/flymake-guile.git"
> +  :ignored-files (".envrc" "guix.scm"))

It would be preferable to track this information in your own repository,
instead of having to update the info in the future in elpa-packages.

Also, it is totally fine to add both packages in a single patch.

--=-=-Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:

> Distopico <distopico@riseup.net> writes:
>
>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>
>>> Distopico <distopico@riseup.net> writes:
>>>
>>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>>
>>>>> Distopico <distopico@riseup.net> writes:
>>>>>
>>>>>> Hi all!
>>>>>>
>>>>>> I'm the author of a new package `flymake-guile` and I
>>>>>> would like to include it in Nongnu ELPA.
>>>>>
>>>>> Just to be sure, you are sure you don't want to include your package in
>>>>> GNU ELPA?
>>>>>
>>>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>>>
>>>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>>>> seem to be much shorter than just defining a regular flymake backend.
>>>>> As there have been some discussions wrt providing a kind of DSL for
>>>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>>>> constructive at this point.  Would you consider updating your package to
>>>>> not use the dependency?  You can check out other flymake-... modes in
>>>>> GNU and NonGNU ELPA for inspiration.
>>>>>
>>>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>>>> and for now I would like to keep `flymake-quickdef`, I have plans to
>>>> write other backend and I don't wanna repeat the same validations and
>>>> code over and over, I'll switch to the DLS when it is implemented.
>>>
>>> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>>>
>>> And just to make sure, you are certain you want to implement this on top
>>> of a DSL?  I have to admit that I am really not a fan of the way that
>>> flymake-quickdef is implemented, but one redeeming feature appears to be
>>> that you could macroexpand it away, then clean the code up.
>>>
>>
>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>> to add the package on NonGNU ELPA?
>
> I am afraid I don't understand your question.

My Question is if remove flymake-quickdef as dependency is a requirement
to merge flymake-guile package into NonGNU ELPA or it's just a
recommendation?   

--=-=-Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQFJBAEBCAAzFiEEvYwofabWO6y953lVmAk6gHJUa/MFAmTx7qAVHGRpc3RvcGlj
b0ByaXNldXAubmV0AAoJEJgJOoByVGvzAyQH/39eYAHu9CJ6IcHJcSDTyumZLOFA
i5UJfOgRFATsCh+aHMRCl36KWTMUGZeFrDYgyh04UZVQ14GotnIReb4tXyFnAILp
uOGd+8sIfqIKceobKji+mYZDem3X80rUjcHhXoNGtZnKh+zjT1cflx1lwf5OfAiy
5pqP4SxIWDGW5jlH0q6lflf5AN5VFSTFin9f2iiSlQBGlToDaqIj0+9/YKiLHgss
tSoOMviGjbi6WoA4fI7c9qq0e305npKDBZVXQn2lpkA6H2fcTc+7yr2lmgG8KVas
NV71B1Dlm94y5mcterGOeVR217qhhDQ90HtiXJOYPrvtpT8QbsdVHCef0L0=S/cZ
-----END PGP SIGNATURE-----
--=-=-=--

Distopico <distopico@riseup.net> writes:

> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Distopico <distopico@riseup.net> writes:
>>
>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>
>>>> Distopico <distopico@riseup.net> writes:
>>>>
>>>>> Hi all!
>>>>>
>>>>> I'm the author of a new package `flymake-guile` and I
>>>>> would like to include it in Nongnu ELPA.
>>>>
>>>> Just to be sure, you are sure you don't want to include your package in
>>>> GNU ELPA?
>>>>
>>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>>
>>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>>> seem to be much shorter than just defining a regular flymake backend.
>>>> As there have been some discussions wrt providing a kind of DSL for
>>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>>> constructive at this point.  Would you consider updating your package to
>>>> not use the dependency?  You can check out other flymake-... modes in
>>>> GNU and NonGNU ELPA for inspiration.
>>>>
>>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>>> and for now I would like to keep `flymake-quickdef`, I have plans to
>>> write other backend and I don't wanna repeat the same validations and
>>> code over and over, I'll switch to the DLS when it is implemented.
>>
>> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>>
>> And just to make sure, you are certain you want to implement this on top
>> of a DSL?  I have to admit that I am really not a fan of the way that
>> flymake-quickdef is implemented, but one redeeming feature appears to be
>> that you could macroexpand it away, then clean the code up.
>>
>
> flymake-collection use an adaptation of flymake-quickdef[1], that is
> a macro similar to the quickdef one[2], could be use quickdef a blocker
> to add the package on NonGNU ELPA?

I am afraid I don't understand your question.

"Dr. Arne Babenhauserheide" <arne_bab@web.de> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>> to add the package on NonGNU ELPA?
>>
>> I am afraid I don't understand your question.
>
> I think it means: "do I have to or can I stick to the plans I have?"
>
> Basically: is this a requirement to be added, or is it a suggestion that
> Distopico can decide not to take.

If Distopico insists on having the `flymake-quickdef' added to NonGNU
ELPA, I will do so, but I advise against it.

> Best wishes,
> Arne

--=-=-Content-Type: text/plain

Distopico <distopico@riseup.net> writes:

> On 2023-09-01, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Distopico <distopico@riseup.net> writes:
>>
>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>
>>>> Distopico <distopico@riseup.net> writes:
>>>>
>>>>> On 2023-08-31, Philip Kaludercic <philipk@posteo.net> wrote:
>>>>>
>>>>>> Distopico <distopico@riseup.net> writes:
>>>>>>
>>>>>>> Hi all!
>>>>>>>
>>>>>>> I'm the author of a new package `flymake-guile` and I
>>>>>>> would like to include it in Nongnu ELPA.
>>>>>>
>>>>>> Just to be sure, you are sure you don't want to include your package in
>>>>>> GNU ELPA?
>>>>>>
>>>>>>> Here the repo: https://framagit.org/flymake-backends/flymake-guile
>>>>>>
>>>>>> I am not familiar with the "flymake-quickdef" package, but it doesn't
>>>>>> seem to be much shorter than just defining a regular flymake backend.
>>>>>> As there have been some discussions wrt providing a kind of DSL for
>>>>>> Flymake backends, I am not sure if adding flymake-quickdef would be that
>>>>>> constructive at this point.  Would you consider updating your package to
>>>>>> not use the dependency?  You can check out other flymake-... modes in
>>>>>> GNU and NonGNU ELPA for inspiration.
>>>>>>
>>>>> Thank you for your feedback, For now I'm fine sending it to NonGNU ELPA,
>>>>> and for now I would like to keep `flymake-quickdef`, I have plans to
>>>>> write other backend and I don't wanna repeat the same validations and
>>>>> code over and over, I'll switch to the DLS when it is implemented.
>>>>
>>>> FWIW it already exists in this form https://github.com/mohkale/flymake-collection.
>>>>
>>>> And just to make sure, you are certain you want to implement this on top
>>>> of a DSL?  I have to admit that I am really not a fan of the way that
>>>> flymake-quickdef is implemented, but one redeeming feature appears to be
>>>> that you could macroexpand it away, then clean the code up.
>>>>
>>>
>>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>>> to add the package on NonGNU ELPA?
>>
>> I am afraid I don't understand your question.
>
> My Question is if remove flymake-quickdef as dependency is a requirement
> to merge flymake-guile package into NonGNU ELPA or it's just a
> recommendation?

It is a strong recommendation.  FWIW I have done the work of
macroexpanding and cleaning the resulting code up (but there is still
some more work to be done), and you can see what I had in mind:


--=-=-Content-Type: text/plain
Content-Disposition: inline

diff --git a/flymake-guile.el b/flymake-guile.el
index d4b17b6..da64903 100644
--- a/flymake-guile.el
+++ b/flymake-guile.el
@@ -3,7 +3,7 @@
 ;; Copyright (c) 2023 Camilo Q.S. (Distopico) <distopico@riseup.net>

 ;; Author: Distopico <distopico@riseup.net>
-;; Package-Requires: ((emacs "26.1") (flymake "1.2.1") (flymake-quickdef "1.0.0"))
+;; Package-Requires: ((emacs "26.1") (flymake "1.2.1"))
 ;; Keywords: language, tools
 ;; Version: 0.3

@@ -35,14 +35,12 @@

 ;;; Code:

-(require 'flymake-quickdef)
-
 (defgroup flycheck-guile nil
   "GNU Guile Flymake backend."
   :prefix "flymake-guile-"
   :group 'flymake)

-(defcustom flymake-guile-guild-binary "guild"
+(defcustom flymake-guile-guild-executable "guild"
   "Name of the Guile `guild' executable."
   :type 'string
   :group 'flymake-guile)
@@ -142,47 +140,122 @@ Also verify if the `STACK-FILE' and the source file are te same."
 		    (- col 1))))
 	  text)))

-(flymake-quickdef-backend flymake-guile-backend
-  :pre-let ((guild-exec (executable-find flymake-guile-guild-binary)))
-  :pre-check (unless guild-exec (error "Cannot find guild executable"))
-  :write-type 'file
-  :proc-form (append
-	      (list guild-exec
-		"compile"
-		"-O0")
-	      (flymake-guile--warning-level-args)
-	      (flymake-guile--load-path-args)
-	      flymake-guile-guild-args
-	      (list fmqd-temp-file))
-  :search-regexp (concat
-		  "\\(.*\\)"
-		  flymake-guile--diag-lnum-rx
-		  "\\(.*\\):[[:space:]]?"
-		  "\\(Syntax error:[[:space:]].*\\|.*\\)$")
-  :prep-diagnostic
-  (let* ((stack_file (match-string 1))
-	 (stack_lnum (match-string 2))
-	 (stack_cnum (match-string 3))
-	 (severity (match-string 4))
-	 (stack_msg (match-string 5))
-	 (report (flymake-guile--get-diagnostic
-		  stack_msg
-		  stack_lnum
-		  stack_cnum
-		  stack_file
-		  fmqd-source))
-	 (lnum (car (car report)))
-	 (cnum (cdr (car report)))
-	 (text (cdr report))
-	 (pos (flymake-diag-region fmqd-source lnum cnum))
-	 (beg (car pos))
-	 (end (cdr pos))
-	 (type (cond
-		((string= severity "warning") :warning)
-		((string= severity "In procedure raise-exception") :error)
-		(t :note)))
-	 (msg (string-trim text)))
-    (list fmqd-source beg end type msg)))
+(defvar-local flymake-guile-process nil)
+
+(defun flymake-make-guile-sentinel (report-fn source temp-dir)
+  "Generate a process sentinel reporting to REPORT-FN.
+The argument SOURCE and TEMP-DIR are respectively used to pass
+the buffer containing the source code being checked and the
+temporary director generated for the checking."
+  (lambda (proc _event)
+    (unless (process-live-p proc)
+      (unwind-protect
+	  (if (eq proc (buffer-local-value 'flymake-guile-process source))
+	      (with-current-buffer source
+		(save-restriction
+		  (widen)
+		  (with-current-buffer (process-buffer proc)
+		    (goto-char (point-min))
+		    (save-match-data
+		      (let ((diags nil))
+			(while (search-forward-regexp
+				(concat
+				 "\\(.*\\)"
+				 flymake-guile--diag-lnum-rx
+				 "\\(.*\\):[[:space:]]?"
+				 "\\(Syntax error:[[:space:]].*\\|.*\\)$")
+				nil t)
+			  (save-match-data
+			    (save-excursion
+			      (let* ((diag-vals
+				      (let* ((stack_file
+					      (match-string 1))
+					     (stack_lnum
+					      (match-string 2))
+					     (stack_cnum
+					      (match-string 3))
+					     (severity
+					      (match-string 4))
+					     (stack_msg
+					      (match-string 5))
+					     (report
+					      (flymake-guile--get-diagnostic
+					       stack_msg
+					       stack_lnum
+					       stack_cnum
+					       stack_file
+					       source))
+					     (lnum (caar report))
+					     (cnum (cdar report))
+					     (text (cdr report))
+					     (pos
+					      (flymake-diag-region
+					       source
+					       lnum
+					       cnum))
+					     (beg (car pos))
+					     (end (cdr pos))
+					     (type
+					      (cond
+					       ((string= severity "warning") :warning)
+					       ((string= severity "In procedure raise-exception")
+						:error)
+					       (t :note)))
+					     (msg (string-trim text)))
+					(list source beg end type msg)))
+				     (diag-beg (nth 1 diag-vals))
+				     (diag-end (nth 2 diag-vals))
+				     (diag-type (nth 3 diag-vals)))
+				(if (and
+				     (integer-or-marker-p diag-beg)
+				     (integer-or-marker-p diag-end))
+				    (when diag-type
+				      (push (apply #'flymake-make-diagnostic diag-vals)
+					    diags))
+				  (with-current-buffer source
+				    (flymake-log
+				     :error
+				     "Got invalid buffer position %s or %s in %s"
+				     diag-beg
+				     diag-end
+				     proc)))))))
+			(funcall
+			 report-fn
+			 (nreverse
+			  diags)))))))
+	    (flymake-log :warning
+			 "Canceling obsolete check %s"
+			 proc))
+	(delete-directory temp-dir t)
+	(kill-buffer (process-buffer proc))))))
+
+(defun flymake-guile-backend (report-fn &rest _args)
+  "Flymake backend for Scheme buffers using GNU Guile.
+For the interpretation of REPORT-FN, consult the Info
+node `(flymake) Backend functions'."
+  (let* ((guild-exec (or (executable-find flymake-guile-guild-executable)
+			 (error "Cannot find guild executable")))
+	 (temp-dir (make-temp-file "flymake-guile-" t))
+	 (temp-file (expand-file-name
+		     (file-name-nondirectory (or (buffer-file-name) (buffer-name)))
+		     temp-dir)))
+    (when (process-live-p flymake-guile-process)
+      (kill-process flymake-guile-process))
+    (save-restriction
+      (widen)
+      (write-region nil nil temp-file nil 'silent)
+      (setq flymake-guile-process
+	    (make-process
+	     :name "flymake-guile-backend-flymake"
+	     :noquery t :connection-type 'pipe
+	     :buffer (generate-new-buffer " *flymake-guile-backend-flymake*")
+	     :sentinel (flymake-make-guile-sentinel report-fn (current-buffer) temp-dir)
+	     :command
+	     (append (list guild-exec "compile" "-O0")
+		     (flymake-guile--warning-level-args)
+		     (flymake-guile--load-path-args)
+		     flymake-guile-guild-args
+		     (list temp-file)))))))

 ;;;###autoload
 (defun flymake-guile ()

--=-=-=--

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


Philip Kaludercic <philipk@posteo.net> writes:

>> flymake-collection use an adaptation of flymake-quickdef[1], that is
>> a macro similar to the quickdef one[2], could be use quickdef a blocker
>> to add the package on NonGNU ELPA?
>
> I am afraid I don't understand your question.

I think it means: "do I have to or can I stick to the plans I have?"

Basically: is this a requirement to be added, or is it a suggestion that
Distopico can decide not to take.

Best wishes,
Arne
=2D-=20
Unpolitisch sein
hei=C3=9Ft politisch sein,
ohne es zu merken.
draketo.de

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmTx60IQHGFybmVfYmFi
QHdlYi5kZQAKCRAT741FJAPD6ylKEADVLAzkgPwycNxZq4h6OuskdOgeSuo+lkxv
+GZM8Ae8Wd/LDcXaarQBJYBYK9ChEjxGtaBKDXDKrv3BC/WoKUIxotkNWCFbbgt9
cOQMyPTYcLZM9e3gbDIzXUJF5pNj8F5fdysRSM/tzrGeEdcpbZJsWfAciE4t4rQZ
kc4wu3AK5wTnRVP/bgemBwLw0QPJXyj5Is6gI2k3RxrRcjulNJx+DzcGGeZ4A77g
Tk1nyPU0DJezv73F8E0zHIoJieDm/0mVuhhqfaz1mxjHa6MKWSC6CpMr9IiMxQWg
VefjUEv90LoWqAZR6rdM1f51lyWwMgpNdPh1jPy9tfFqshpVMn67dWL2mS7A4eK6
4qQfEEyt8DpqCHlacgLq6fqumGjzWRbzwhn6nX+IHxAVwEP3LS6yvN8jDqv3coW8
MLs2Dt4akXyTVM7dIubsJkcvddI+zbP3+D10IcyPgOvVhbkBR/XS0+zvH3nc9L56
eJ+v3EOcLcpifoGtVMqWYfLTz4n9z2zR47T9idZbBIYPJqsY7h2XHjGBxzOduP1a
MZFXWo3F6Y8lkLWTxu5N7JVOoITPUyKF/b37cokHVLTWCwJBvxUCj2g/sY7A15Gg
3QgGCRROqdle+2o7M7IDF9Kq3uG1tLyt8f4MUINxZmbkDgGW9hrAvIv7OoujHgS6
3R9wuk4j3YjEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmTx60IQHGFy
bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSBJKA/4iVPu8XMEnQ7un/puVSuaNByEw
OEB4z8aUVYeM9m//tJcFYtyiApwpsJRaMlqjtsSBwZ5TqvdWov7G2VZRNF7E7djB
oGk7PjsGueMCBJxj0jrH4yx/qK6t5RN/MDfXJKjY0vKFO5CyVHvpJCIGil97TiI3
9wIHW1oP1wInR6BmWQ==
=sW1c
-----END PGP SIGNATURE-----
--=-=-=--