[PATCH] Move flags for preprocessing linker scripts to rule

Thread View: gmane.linux.kernel

2 messages

[T] Back to Threads [V] Tree View [G] Group Articles

2 total messages Started by Bastian Blank Sat, 17 Sep 2005 16:49

#307690

Author: Bastian Blank
Date: Sat, 17 Sep 2005 16:49

69 lines
2035 bytes

--gKMricLos+KVdGMg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Move CPPFLAGS_vmlinux.lds settings into the .lds.S -> .lds rule. Any of
the remaining CPPFLAGS definitions for .lds.S preprocessing sets this
options.

Add -undef to avoid definition of any system-specific macros. This makes
the explicit undefines unnecessary.

Signed-off-by: Bastian Blank <waldi@debian.org>

---

 Makefile               |    5 -----
 scripts/Makefile.build |    2 +-
 2 files changed, 1 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -827,11 +827,6 @@ prepare0: archprepare FORCE
 # All the preparing..
 prepare prepare-all: prepare0
 
-#	Leave this as default for preprocessing vmlinux.lds.S, which is now
-#	done in arch/$(ARCH)/kernel/Makefile
-
-export CPPFLAGS_vmlinux.lds += -P -C -U$(ARCH)
-
 # Single targets
 # ---------------------------------------------------------------------------
 
diff --git a/scripts/Makefile.build b/scripts/Makefile.build
--- a/scripts/Makefile.build
+++ b/scripts/Makefile.build
@@ -234,7 +234,7 @@ targets += $(extra-y) $(MAKECMDGOALS) $(
 # Linker scripts preprocessor (.lds.S -> .lds)
 # ---------------------------------------------------------------------------
 quiet_cmd_cpp_lds_S = LDS     $@
-      cmd_cpp_lds_S = $(CPP) $(cpp_flags) -D__ASSEMBLY__ -o $@ $<
+      cmd_cpp_lds_S = $(CPP) -P -C -undef $(cpp_flags) -D__ASSEMBLY__ -o $@ $<
 
 %.lds: %.lds.S FORCE
 	$(call if_changed_dep,cpp_lds_S)

-- 
You!  What PLANET is this!
		-- McCoy, "The City on the Edge of Forever", stardate 3134.0

--gKMricLos+KVdGMg
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iEYEARECAAYFAkMsLRIACgkQnw66O/MvCNGtTACfeh+5EK5MX5wJpMSeSZ2XcQkt
H4MAoIYGk9Jqm4EaFKbLA1uddf6Phiro
¢aT
-----END PGP SIGNATURE-----

--gKMricLos+KVdGMg--

Re: [PATCH] Move flags for preprocessing linker scripts to rule

#307781

Author: Sam Ravnborg
Date: Sun, 18 Sep 2005 09:38

11 lines
374 bytes

Hi Bastian.

> Move CPPFLAGS_vmlinux.lds settings into the .lds.S -> .lds rule. Any of
> the remaining CPPFLAGS definitions for .lds.S preprocessing sets this
> options.

I fail to see how arch specific settings are picked up.
See for example um that set CPPFLAGS_vmlinux in arch/um/Makefile.
There is no way this value is visible when buiding
arch/um/kernel/Makefile.

	Sam

Thread Navigation

This is a paginated view of messages in the thread with full content displayed inline.

Messages are displayed in chronological order, with the original post highlighted in green.

Use pagination controls to navigate through all messages in large threads.

Back to All Threads